htmlfiles: Handle localStorage not accessible #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, if based on the browser's settings - localStorage is not accessible, fallback and don't save the sort-columns into localStorage. While the UX is a little inconvenient, at least the page doesn't break - sorting on columns is still possible, but not retained between pages.
AbdealiLoKo
commented
Feb 24, 2020
| @@ -172,7 +172,10 @@ coverage.index_ready = function ($) { | |||
| // Look for a localStorage item containing previous sort settings: | |||
| var sort_list = []; | |||
| var storage_name = "COVERAGE_INDEX_SORT"; | |||
| var stored_list = localStorage.getItem(storage_name); | |||
| var stored_list = undefined; | |||
| try { | |||
There was a problem hiding this comment.
Note - didn't look like there was any better way of testing this as merely accessing the variable caused the error. So, try/catch seemed to be the only option
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 94.02% 94.09% +0.06%
==========================================
Files 86 86
Lines 12089 12089
Branches 1210 1210
==========================================
+ Hits 11367 11375 +8
+ Misses 588 580 -8
Partials 134 134
Continue to review full report at Codecov.
|
|
Thanks! |
|
This became 48c73b8 |
|
This is now available in coverage v5.0.4 |
This was referenced May 29, 2021
This was referenced Jun 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, if based on the browser's settings - localStorage
is not accessible, fallback and don't save the sort-columns into
localStorage.
While the UX is a little inconvenient, at least the page doesn't
break - sorting on columns is still possible, but not retained
between pages.
Resolves #944