test: Memory leak reproduction for futures #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brooooooklyn
force-pushed
the
feat/future-leak-repro
branch
from
3bed002
to
81498ec
Compare
|
I think it's related to #1403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When attempting to update to napi-rs 2.10.0, our tests caught a new memory leak across all Node.JS version. I can confirm that the issue still exists on 2.10.3 as well. After some digging through, I think I narrowed it down to Future -> Promise conversion. This PR adds a reproduction to the memory test suite: if you run the script manually, you can see heap usage steadily climbing. And if you use low enough
--max_old_space_sizeit will eventually crash with out-of-memory error. Hope it will help with fixing it — at the moment we had to pin allnapi-rspackages to 2.9.0, but we'd like to unblock the update.