Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update napi dependencies from 2.9.1 to 2.10.1 #3521

Closed
Jolg42 opened this issue Dec 16, 2022 · 2 comments
Closed

update napi dependencies from 2.9.1 to 2.10.1 #3521

Jolg42 opened this issue Dec 16, 2022 · 2 comments
Assignees
@SevInf
Labels
dependencies Pull requests that update a dependency file kind/tech A technical change. team/client Issue for team Client. tech/engines/query engine Issue in the Query Engine tech/engines Issue for tech Engines.
Milestone
4.9.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Dec 16, 2022

See discussion in Slack

And PR
#3387

Note that the PR is blocked, as updating to 2.10.0 or 2.10.1 fails the memory tests in prisma/prisma
@Jolg42 Jolg42 added process/candidate tech/engines/query engine Issue in the Query Engine tech/engines Issue for tech Engines. kind/tech A technical change. team/client Issue for team Client. dependencies Pull requests that update a dependency file labels Dec 16, 2022
@Jolg42 Jolg42 mentioned this issue Jan 2, 2023
Merged
@Jolg42 Jolg42 added this to the 4.9.0 milestone Jan 2, 2023
@Jolg42
Copy link
Member Author

Jolg42 commented Jan 2, 2023

Closed by #3554

@Jolg42 Jolg42 closed this as completed Jan 2, 2023
@Jolg42
Copy link
Member Author

Jolg42 commented Jan 2, 2023

Updated to https://github.com/napi-rs/napi-rs/releases/tag/napi%402.10.4
memory leak fix by @SevInf napi-rs/napi-rs#1413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SevInf SevInf

Labels
dependencies Pull requests that update a dependency file kind/tech A technical change. team/client Issue for team Client. tech/engines/query engine Issue in the Query Engine tech/engines Issue for tech Engines.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
2 participants
@SevInf @Jolg42