Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Memory leak reproduction for futures #1413

Merged
merged 2 commits into from Dec 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions memory-testing/index.mjs
Expand Up @@ -5,3 +5,4 @@ await createSuite('tokio-future')
await createSuite('serde')
await createSuite('tsfn')
await createSuite('buffer')
await createSuite('returns-future')
26 changes: 26 additions & 0 deletions memory-testing/returns-future.mjs
@@ -0,0 +1,26 @@
import { createRequire } from 'module'

import { displayMemoryUsageFromNode } from './util.mjs'

const initialMemoryUsage = process.memoryUsage()

const require = createRequire(import.meta.url)

const api = require(`./index.node`)

async function main() {
let i = 1
// eslint-disable-next-line no-constant-condition
while (true) {
await api.returnsFuture()
if (i % 100000 === 0) {
displayMemoryUsageFromNode(initialMemoryUsage)
}
i++
}
}

main().catch((e) => {
console.error(e)
process.exit(1)
})
3 changes: 3 additions & 0 deletions memory-testing/src/lib.rs
Expand Up @@ -171,3 +171,6 @@ pub fn buffer_pass_through(buffer: Buffer) -> Buffer {
pub fn array_buffer_pass_through(array_buffer: Uint8Array) -> Uint8Array {
array_buffer
}

#[napi]
pub async fn returns_future() {}
15 changes: 9 additions & 6 deletions memory-testing/test-util.mjs
Expand Up @@ -44,14 +44,19 @@ export async function createSuite(testFile, maxMemoryUsage) {
const stats = await container.stats()

let shouldAssertMemoryUsage = false

const initialMemoryUsage = await new Promise((resolve, reject) => {
let initialMemoryUsage
await new Promise((resolve, reject) => {
const initialDate = Date.now()
stats.on('data', (d) => {
const { memory_stats } = JSON.parse(d.toString('utf8'))
resolve(memory_stats.usage)
if (Date.now() - initialDate > 10000 && !shouldAssertMemoryUsage) {
resolve()
initialMemoryUsage = memory_stats.usage
shouldAssertMemoryUsage = true
}
if (shouldAssertMemoryUsage && memory_stats?.usage) {
const memoryGrowth = memory_stats.usage - initialMemoryUsage
if (memoryGrowth > maxMemoryUsage ?? initialMemoryUsage) {
if (memoryGrowth > (maxMemoryUsage ?? initialMemoryUsage)) {
console.info(
chalk.redBright(
`Potential memory leak, memory growth: ${prettyBytes(
Expand All @@ -72,8 +77,6 @@ export async function createSuite(testFile, maxMemoryUsage) {

await sleep(60000)

shouldAssertMemoryUsage = true

try {
await container.stop()
await container.remove()
Expand Down