Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make napari/tests a package #912

Closed
wants to merge 1 commit into from
Closed

Make napari/tests a package #912

wants to merge 1 commit into from

Conversation

ttung
Copy link
Contributor

@ttung ttung commented Jan 27, 2020

Description

I considered making all the tests namespace packages, but it turns out pytest chokes on namespace packages. So this is the best solution for now.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

Fixes #875

How has this been tested?

made a distribution (python setup.py sdist) then installed it in a separate virtualenv. then ran tests (pytest --pyargs napari).

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sofroniewn sofroniewn added this to the 0.2.11 milestone Jan 27, 2020
@sofroniewn sofroniewn added the bug Something isn't working label Jan 27, 2020
@sofroniewn sofroniewn mentioned this pull request Jan 27, 2020
Closed
8 tasks
@ttung ttung mentioned this pull request Jan 27, 2020
Closed
@sofroniewn sofroniewn requested a review from jni January 27, 2020 21:37
Make napari/tests a package
84b1bdc 
I considered making all the tests namespace packages, but it turns out pytest [chokes](pytest-dev/pytest#3396) [on](pytest-dev/pytest#1927) [namespace packages](pytest-dev/pytest#478).  So this is the best solution for now.

Test plan: made a distribution (python setup.py sdist) then installed it in a separate virtualenv.  then ran tests (`pytest --pyargs napari`).

Fixes napari#875
@ttung ttung closed this Jan 28, 2020
@ttung ttung deleted the testable-install branch January 28, 2020 20:25
@ttung ttung restored the testable-install branch January 28, 2020 21:29
@ttung ttung deleted the testable-install branch February 4, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni Awaiting requested review from jni

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.11
Development

Successfully merging this pull request may close these issues.

Testing a pip install doesn't work
2 participants
@ttung @sofroniewn