Exclude benchmarks from the list of packages found

[ttung]

Description

The benchmarks directory was not meant to be packaged for distribution.

Type of change

• Bug-fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

References

Fixes #910

How has this been tested?

% python setup.py sdist
% mkdir /tmp/4
% cd /tmp/4
% pip install ~/imaging/napari/dist/napari-0+unknown.tar.gz
% python 
Python 3.7.5 (default, Oct 28 2019, 07:13:20) 
[Clang 11.0.0 (clang-1100.0.33.8)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import benchmarks
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'benchmarks'
>>> ^D
%

Final checklist:

• My PR is the minimum possible work for the desired functionality
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[kne42]

thanks!

[sofroniewn]

This will close #910. @ttung will the benchmarks will still get included in the pip install? i.e. if i want to run them i can, but they just won't be available as a top level import, or will that code not even get distributed now?

I don't know what the conventions / norms around this are so I'll ultimately defer to others who know more. It makes sense that we shouldn't be adding something that appears under import benchmarks but it might still be nice for people to run the benchmarking suites even if they got napari from a pip install? Or maybe that isn't needed? What does @jni think?

[ttung]

I think it's far better to bundle these into napari.benchmarks if you want them distributed.

[sofroniewn]

I think it's far better to bundle these into napari.benchmarks if you want them distributed.

Makes sense - I do see this as quite analogous to #875 too, so we might want to mirror whatever solution we come up with there here - see #912

[ttung]

Dumping this one...