Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB test correction #2442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MariaDB test correction #2442

wants to merge 1 commit into from

Conversation

rusher
Copy link

@rusher rusher commented Dec 4, 2020

change statistics test (mariadb doesn't have flush_tables)
change load data infile disable (MariaDB return a specific error 4166 : ER_LOAD_INFILE_CAPABILITY_DISABLED)
ensure load data is enable server side (mysql 8/mariadb 10.5)

change statistics test (mariadb doesn't have flush_tables)
change load data infile disable (MariaDB return a specific error 4166 : ER_LOAD_INFILE_CAPABILITY_DISABLED)
ensure load data is enable server side (mysql 8/mariadb 10.5)
@rusher rusher changed the title Adding current GA version to test suite MariaDB test correction Dec 4, 2020
@rusher rusher mentioned this pull request Dec 4, 2020
@rusher

This comment was marked as resolved.

@grooverdan
Copy link
Contributor

Thanks @rusher for setting me on the right track.

https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/dockerfiles/ecofiles/test-mysqljs.sh#L43-L56 is the changes to integration tests that I needed to do to get it successful on all mariadb versions (CI tests: https://buildbot.mariadb.org/#/builders/123).

As such test-statistics.js needs a common.minVersion(connection, 10, 5, 0) and the other tests, test-bad-credentials.js and test-server-timeout-disconnect.js needing version dependent tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants