Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mariadb testing #2438

Closed
wants to merge 3 commits into from
Closed

Fix Mariadb testing #2438

wants to merge 3 commits into from

Conversation

rusher
Copy link

@rusher rusher commented Nov 30, 2020

MariaDB 5.5 and 10.0 version are EOL, Adding current GA version to test suite
change statistics test (mariadb doesn't have flush_tables)
change load data infile disable (MariaDB return a specific error 4166 : ER_LOAD_INFILE_CAPABILITY_DISABLED)

Copy link
Member

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.travis.yml Outdated Show resolved Hide resolved
@rusher
Copy link
Author

rusher commented Dec 1, 2020

Change as requested.
I've added some utility functions to common in order to distinguish MariaDB from MySQL server and required minimum version.

Adding current GA version to test suite
change statistics test (mariadb doesn't have flush_tables)
disable load data infile test for server that disabled this capability if not explicitly enable (MariaDB 10.5 / MySQL 8)
Adding current GA version to test suite
change statistics test (mariadb doesn't have flush_tables)
disable load data infile test for server that disabled this capability if not explicitly enable (MariaDB 10.5 / MySQL 8)
…rush

� Conflicts:
�	test/common.js
�	test/integration/connection/test-load-data-infile-disable.js
�	test/integration/connection/test-load-data-infile.js
�	test/integration/connection/test-multiple-statements-load-data-infile.js
@rusher
Copy link
Author

rusher commented Dec 4, 2020

Closed, replaced by #2442, to have only one commit

@rusher rusher closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants