Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'http-server' with 'serve'. #12455

Merged
merged 1 commit into from Oct 23, 2017
Merged

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Oct 21, 2017

I just spent a silly amount of time stuck on what turned out to be incorrect content-type encoding added by the http-server module, while trying to test out the ImageBitmapLoader example. 馃槴

The bug has been open a while, so to save others this particular future pain I suggest changing to zeit/serve. It also has slightly prettier formatting, for what that's worth:

screen shot 2017-10-20 at 6 00 11 pm

@donmccurdy
Copy link
Collaborator Author

^to clarify, the ImageBitmapLoader example works fine as-is, but only supports Chrome. I tried to update it to support Firefox, and this was an unexpected obstacle.

@fernandojsg
Copy link
Collaborator

@donmccurdy what about changing it for https://github.com/tapio/live-server so we could have live reload for free? quite handy when prototyping things :) Could you try if it works with your example?

@donmccurdy
Copy link
Collaborator Author

live-server works correctly, too. Can switch to that if live reload would be wanted. :)

@fernandojsg
Copy link
Collaborator

fernandojsg commented Oct 22, 2017

Probably serve will be faster than live-server as it doesn't need to inject any extra code or listen for anything, so pros and cons, no strong opinion here. Just up to the maintainers :D

@mrdoob mrdoob merged commit f8c1d1a into mrdoob:dev Oct 23, 2017
@mrdoob
Copy link
Owner

mrdoob commented Oct 23, 2017

Thanks!

@donmccurdy donmccurdy deleted the deps-serve branch February 8, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants