Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Go back to serve 6.5.8 #14264

Merged
merged 1 commit into from Jun 11, 2018
Merged

Dev: Go back to serve 6.5.8 #14264

merged 1 commit into from Jun 11, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 10, 2018

Even with cleanUrls set to false, the editor does not work with the new serve. I suggest we go back to 6.5.8 for now which is recommended in the following post:

https://github.com/zeit/serve/releases/tag/7.0.0

We can still upgrade in the feature if serve becomes more flexible.

@Mugen87 Mugen87 mentioned this pull request Jun 10, 2018
@Mugen87 Mugen87 merged commit c460cb1 into mrdoob:dev Jun 11, 2018
@donmccurdy
Copy link
Collaborator

Thanks for rolling that back, do you know what's breaking in the Editor in the newer version?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 11, 2018

I have not analysed the problem in detail so far but for some reasons the server performed HTTP 301 redirects. So it was not possible to call http://localhost:8080/editor/

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 11, 2018

I'm in general irritated by the changes the developers made in the new serve. Going back to 6.5.8 is at least for now the best for the project and my stress level...

@mrdoob mrdoob added this to the r94 milestone Jun 12, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2018

Thanks!

@donmccurdy
Copy link
Collaborator

Seems like that cleanUrls:false setting causes http://localhost:8080/editor/ to serve a directory listing, showing all the files in the folder rather than index.html. I don't see any combination of settings in the new serve that prevent foo.html from redirecting to foo, without also losing the ability to treat foo/index.html as foo/ as before. 😐

@mrdoob
Copy link
Owner

mrdoob commented Jun 17, 2018

What do you guys think about switching to http-server? That's the one I usually use and it has never given me problems...

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 18, 2018

I'm fine with this.

@donmccurdy
Copy link
Collaborator

donmccurdy commented Jun 18, 2018

The original reason for the change is described by #12455, http-server has a bug that broke ImageBitmap loading in Firefox (http-party/http-server#296). It could also be fixed in Firefox someday, but I see no progress (https://bugzilla.mozilla.org/show_bug.cgi?id=1413806) and it's not obvious that Firefox was doing the wrong thing.

It sounds like the purpose of serve has changed, it now matches the Zeit Now static deployment environment, which is nice for static sites but diverges from typical static file hosts like GitHub Pages. I'd suggest:

a. Stick with serve 6.5.8 for now, and wait for a response on vercel/serve#431
b. Move to something else like live-server

@mrdoob
Copy link
Owner

mrdoob commented Jun 18, 2018

I leave this up to you guys, I don't use npm dev nor npm dev-test.

I think it was @fernandojsg and @gero3 who introduced all this?

@donmccurdy
Copy link
Collaborator

donmccurdy commented Jun 18, 2018

I think it was @fernandojsg and @gero3 who introduced all this?

That was me, in #12455. Unless they (Zeit) choose to provide options matching typical static hosting behavior, maybe it's no longer a good choice as a development server. I've left some comments and I think there's a reasonable chance they'll address them, but we can certainly also use something else.

I'd welcome feedback from others on alternatives, if you have something you like and that provides directory listings. I generally use serve, but I also use Zeit for hosting so those "just work" together. budo is also good but does too much for this situation. live-server is the only other alternative I'm familiar with.

@fernandojsg
Copy link
Collaborator

I have no strong opinion although I agree that bude looks like too much for the needs of the projects, I've been using using live-server for a while and no complains so far though.

@donmccurdy
Copy link
Collaborator

Seeing some progress on the http-server issue (http-party/http-server#296), let's wait until either that or the Zeit Serve question are resolved.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 19, 2018

Makes sense. The further use of serve 6.5.8 should be no problem. At least for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants