bug-1878000: reduce spam from make run
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
changed the title
make runmake run
|
We should land this after PR #965 because that picks up circleci fixes including updating to a more recent version of Docker. |
smarnach
approved these changes
Feb 1, 2024
docker/images/fakesentry/Dockerfile
Outdated
Comment on lines
3
to
4
| ARG groupid=5000 | ||
| ARG userid=5000 |
There was a problem hiding this comment.
I think these arguments are unused now and can be removed.
|
The Kent upgrade picks up changes to logging that reduce logging spam. It's not as applicable here because Antenna doesn't have the service healthchecks that Tecken has, but when we implement those, we'll want the fixes in Kent 1.2.0 that quell the logging that triggered with the healthchecks every second. |
relud
reviewed
Feb 1, 2024
willkg
force-pushed
the
willkg-1878000-spammy
branch
from
160b048
to
6291d05
Compare
relud
approved these changes
Feb 1, 2024
This reduces the copious output of backing services when running `make run`.
This upgrades Kent to 1.2.0 to pick up fixes to logging and other things. This also updates the Dockerfile to use the same base image Antenna does.
This moves the `--progress` flag to the global section so docker doesn't complain.
This switches to specifying which services to attach to rather than which ones _not_ to attach to.
willkg
force-pushed
the
willkg-1878000-spammy
branch
from
6291d05
to
ad6e26d
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the spam in the output when running
make runby explicitly not attaching to backing services and improving Kent logging.While doing that, I saw this output when running
make build:So I fixed that, too.