-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug-1877856: run systemtest in CI #965
Conversation
4ac6ae5
to
4ab9017
Compare
try: | ||
yield conn.getresponse() | ||
finally: | ||
conn.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this change I was getting test failures due to unclosed socket
@@ -8,7 +8,7 @@ version: 2.1 | |||
jobs: | |||
main: | |||
docker: | |||
- image: cimg/base:2023.01 | |||
- image: cimg/base:2024.01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker compose up --wait-timeout
requires a newer version of docker compose
@@ -18,7 +18,7 @@ jobs: | |||
- checkout | |||
|
|||
- setup_remote_docker: | |||
version: 20.10.18 | |||
version: docker24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker 20 is deprecated by circleci and will start experiencing scheduled brownouts in february https://discuss.circleci.com/t/remote-docker-image-deprecations-and-eol-for-2024/50176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We should probably update the systemtests/README.rst
and whatever else needs updating in the systemtests now that it's being run in CI.
i'll file a follow-up PR so that i can merge this and unblock #968 |
No description provided.