Merge pull request doctrine#3598 from morozov/deprecate-unused

Deprecated some unused code bits
morozov · Jun 7, 2019 · b75cf20 · b75cf20
2 parents 97b7305 + 9706ef9
commit b75cf20
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,13 @@
 # Upgrade to 2.10
 
+## Deprecated `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()`
+
+Method `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()` has been deprecated as no longer used.
+
+## Deprecated `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM`
+
+Property `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM` has been deprecated as not used.
+
 ## Deprecated `Doctrine\DBAL\Driver::getName()`
 
 Relying on the name of the driver is discouraged. For referencing the driver, use its class name.

diff --git a/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php b/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php
@@ -58,7 +58,11 @@ class OCI8Statement implements IteratorAggregate, Statement
     /** @var OCI8Connection */
     protected $_conn;
 
-    /** @var string */
+    /**
+     * @deprecated
+     *
+     * @var string
+     */
     protected static $_PARAM = ':param';
 
     /** @var int[] */

diff --git a/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php b/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
@@ -2140,6 +2140,8 @@ protected function getRenameIndexSQL($oldIndexName, Index $index, $tableName)
     /**
      * Common code for alter table statement generation that updates the changed Index and Foreign Key definitions.
      *
+     * @deprecated
+     *
      * @return string[]
      */
     protected function _getAlterTableIndexForeignKeySQL(TableDiff $diff)