Skip to content

Commit

Permalink
Deprecated some unused code bits
Browse files Browse the repository at this point in the history
  • Loading branch information
morozov committed Jun 6, 2019
1 parent 97b7305 commit 9706ef9
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
8 changes: 8 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Upgrade to 2.10

## Deprecated `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()`

Method `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()` has been deprecated as no longer used.

## Deprecated `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM`

Property `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM` has been deprecated as not used.

## Deprecated `Doctrine\DBAL\Driver::getName()`

Relying on the name of the driver is discouraged. For referencing the driver, use its class name.
Expand Down
6 changes: 5 additions & 1 deletion lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ class OCI8Statement implements IteratorAggregate, Statement
/** @var OCI8Connection */
protected $_conn;

/** @var string */
/**
* @deprecated
*
* @var string
*/
protected static $_PARAM = ':param';

/** @var int[] */
Expand Down
2 changes: 2 additions & 0 deletions lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
Original file line number Diff line number Diff line change
Expand Up @@ -2140,6 +2140,8 @@ protected function getRenameIndexSQL($oldIndexName, Index $index, $tableName)
/**
* Common code for alter table statement generation that updates the changed Index and Foreign Key definitions.
*
* @deprecated
*
* @return string[]
*/
protected function _getAlterTableIndexForeignKeySQL(TableDiff $diff)
Expand Down

0 comments on commit 9706ef9

Please sign in to comment.