New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django main to tox envlist. #953
Conversation
@bluetech again we have a problem in testing with django
I've checked the |
Thanks for the PR @hramezani! It might take me a while to look at the failure, but I'll definitely check it out. From the error it is related to the experimental multi-db support, which also causes some (flaky?) sqlite failures in other PRs. Any investigation you can make (e.g. what changed in that django commit) would be great. |
5597c92
to
c971205
Compare
@bluetech I think we had a problem with Django main because they removed I've added it to Also, it seems we have a problem with Github action. |
pytest_django/fixtures.py
Outdated
PytestDjangoTestCase.setUpClass() | ||
if VERSION >= (4, 0): | ||
request.addfinalizer(PytestDjangoTestCase.django_tear_down_class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the following work, instead of copying django_tear_down_class
over?
request.addfinalizer(PytestDjangoTestCase.django_tear_down_class) | |
request.addfinalizer(PytestDjangoTestCase.doClassCleanups) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, perfect!
c971205
to
ab263af
Compare
Not sure |
No, it looks like more-itertools/more-itertools#578, which will hopefully resolve itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hramezani! I will be aiming for a release this weekend.
No description provided.