New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRIVERS-2489 Properly skip createChangeStream tests on serverless #1346
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f116979
DRIVERS-2489 Properly skip createChangeStream tests on serverless
ShaneHarvey 7e2a7cb
DRIVERS-2489 Bump to schemaVersion 1.4 for serverless:forbid support
ShaneHarvey 3eebc1b
DRIVERS-2489 Remove unneeded change stream lines from retryable write…
ShaneHarvey 9777086
DRIVERS-2489 Remove more unneeded changes from retryable-writes template
ShaneHarvey 5f66680
DRIVERS-2489 Make test names unique
ShaneHarvey 2f7bcd7
DRIVERS-2489 Skip $listLocalSessions on serverless too
ShaneHarvey File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found another problem with these tests. The createChangeStream test names are duplicated,
"createChangeStream succeeds after retryable handshake network error"
appears 3 times. This is a problem since test descriptions are expected to be unique within a file.