DRIVERS-2489 Properly skip createChangeStream tests on serverless #1346
Conversation
ShaneHarvey
requested review from
jmikola and
eramongodb
and removed request for
a team
|
Tests are passing in Python here: mongodb/mongo-python-driver#1116 |
| {%- if operation.operation_name == 'createChangeStream' %} | ||
| runOnRequirements: | ||
| - serverless: forbid | ||
| {%- endif %} |
There was a problem hiding this comment.
Was this just done for consistency? It seems unlikely that createChangeStream would ever be tested for retryable writes.
There was a problem hiding this comment.
It seems unlikely
Note, this was also why the retryable writes template file does not contain other change stream specific behavior such as saveResultAsEntity.
There was a problem hiding this comment.
Oh I did this without thinking. Removed.
| @@ -209,6 +210,8 @@ tests: | |||
| commandName: listDatabases | |||
|
|
|||
| - description: "createChangeStream succeeds after retryable handshake network error" | |||
There was a problem hiding this comment.
I just found another problem with these tests. The createChangeStream test names are duplicated, "createChangeStream succeeds after retryable handshake network error" appears 3 times. This is a problem since test descriptions are expected to be unique within a file.
|
Okay I removed the unneeded retryable-writes template changes and fixed the duplicate descriptions problem (by adding operation.object). |
This PR fixes an issue with the tests added in #1336
Change streams don't yet work on serverless so we have to skip createChangeStream tests there.
Please complete the following before merging: