Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1288

Merged
merged 8 commits into from Sep 9, 2022
Merged

DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1288

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71cb7ed
DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt …
kevinAlbs Jul 29, 2022
cf4b53c
update changelog, last modified date, and version
kevinAlbs Jul 29, 2022
9ee1a5f
clarify dependencies may need upgrade
kevinAlbs Aug 2, 2022
f92d030
Add "If applicable"
kevinAlbs Aug 2, 2022
9df8d13
use MUST, not SHOULD
kevinAlbs Aug 2, 2022
ef64242
specify versions 1.5.1 or 1.5.0 are only versions affected
kevinAlbs Aug 2, 2022
b8b8e78
include missing "that"
kevinAlbs Aug 2, 2022
26a8294
Merge branch 'master' into error.D2408
kevinAlbs Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions source/client-side-encryption/client-side-encryption.rst
View file
Open in desktop
Expand Up @@ -10,8 +10,8 @@ Client Side Encryption
:Status: Accepted
:Type: Standards
:Minimum Server Version: 4.2 (CSFLE), 6.0 (Queryable Encryption)
:Last Modified: 2022-06-30
:Version: 1.10.0
:Last Modified: 2022-07-29
:Version: 1.10.1

.. _lmc-c-api: https://github.com/mongodb/libmongocrypt/blob/master/src/mongocrypt.h.in

Expand Down Expand Up @@ -976,6 +976,13 @@ being created. If ``keyMaterial`` is given, the custom key material is used for
encrypting and decrypting data. Otherwise, the key material for the new data key
is generated from a cryptographically secure random device.

rewrapManyDataKey
-----------------

If applicable, drivers MUST document users must upgrade dependencies if necessary to avoid being impacted by MONGOCRYPT-464.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...document that users...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


If applicable, drivers MUST return an error if rewrapManyDataKey is called with libmongocrypt 1.5.1 or older.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrapManyDataKey was new in 1.5.0, right? If so, say 1.5.1 or 1.5.0 instead of 1.5.1 or older.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Done.


RewrapManyDataKeyOpts
---------------------

Expand Down Expand Up @@ -2387,6 +2394,7 @@ Changelog
:align: left

Date, Description
22-07-29, Prohibit ``rewrapManyDataKey`` with libmongocrypt <= 1.5.1.
22-06-30, Add behavior for automatic AWS credential loading in ``kmsProviders``.
22-06-29, Clarify bulk write operation expectations for ``rewrapManyDataKey()``.
22-06-27, Remove ``createKey``.
Expand Down