Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1288

Merged
merged 8 commits into from Sep 9, 2022
Merged

DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1288

merged 8 commits into from Sep 9, 2022

Conversation

kevinAlbs
Copy link
Contributor

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files. N/A
  • Test changes in at least one language driver. Tested in Go
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@kevinAlbs kevinAlbs marked this pull request as ready for review July 30, 2022 20:02
@kevinAlbs kevinAlbs requested a review from a team as a code owner July 30, 2022 20:02
@kevinAlbs kevinAlbs requested review from comandeo, eramongodb and behackett and removed request for a team and comandeo July 30, 2022 20:02
@kevinAlbs
clarify dependencies may need upgrade
9ee1a5f
@kevinAlbs
Add "If applicable"
f92d030 
This may not be applicable to drivers that have separate bindings releases.
@kevinAlbs
use MUST, not SHOULD
9df8d13
behackett
behackett reviewed Aug 2, 2022
View reviewed changes
source/client-side-encryption/client-side-encryption.rst Outdated

If applicable, drivers MUST document users must upgrade dependencies if necessary to avoid being impacted by MONGOCRYPT-464.

If applicable, drivers MUST return an error if rewrapManyDataKey is called with libmongocrypt 1.5.1 or older.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrapManyDataKey was new in 1.5.0, right? If so, say 1.5.1 or 1.5.0 instead of 1.5.1 or older.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Done.

behackett
behackett reviewed Aug 2, 2022
View reviewed changes
source/client-side-encryption/client-side-encryption.rst Outdated
rewrapManyDataKey
-----------------

If applicable, drivers MUST document users must upgrade dependencies if necessary to avoid being impacted by MONGOCRYPT-464.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...document that users...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kevinAlbs kevinAlbs merged commit d136699 into mongodb:master Sep 9, 2022
kmahar pushed a commit that referenced this pull request Sep 15, 2022
@kevinAlbs @kmahar
DRIVERS-2408 error if RewrapManyDataKey is called with libmongocrypt …
81e8142 
…< 1.5.2 (#1288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackett behackett behackett approved these changes

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinAlbs @behackett @eramongodb