Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-1945: Generate sitemaps #345

Merged
merged 2 commits into from Jan 29, 2021
Merged

DOP-1945: Generate sitemaps #345

merged 2 commits into from Jan 29, 2021

Conversation

sophstad
Copy link
Member

[DOP-1945] [Realm Sitemap] Generates a sitemap.xml file for each build.

@sophstad sophstad requested review from rayangler, i80and and schmalliso and removed request for rayangler January 29, 2021 19:06
Copy link
Collaborator

@schmalliso schmalliso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Just for my edification: why are we replacing ES6 export with module.exports?

@sophstad
Copy link
Member Author

Just for my edification: why are we replacing ES6 export with module.exports?

@i80and It's an absolutely whack requirement wherein Gatsby's node environment is incompatible with ES6 syntax. You can read a lot of people bicker about it here: gatsbyjs/gatsby#7810

@sophstad sophstad merged commit 42665aa into master Jan 29, 2021
@sophstad sophstad deleted the DOP-1945 branch January 29, 2021 20:01
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants