Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify canonical implementation #344

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Simplify canonical implementation #344

merged 2 commits into from
Jan 29, 2021

Conversation

sophstad
Copy link
Member

@sophstad sophstad commented Jan 29, 2021

[Realm Staging] Better way of doing #334; let's rely on Gatsby's official plugin! All pages should still include <link rel="canonical" (with trailing slash) in their source.

@rayangler
Copy link
Collaborator

rayangler commented Jan 29, 2021

Do canonical urls show up with trailing slashes for you? This is what I see when I view the page source of this page:

<link rel="canonical" href="https://docs.mongodb.com/master/realm/sophstad/improve-canonical/graphql/authenticate" data-baseprotocol="https:" data-basehost="docs.mongodb.com"/>

@sophstad
Copy link
Member Author

sophstad commented Jan 29, 2021

@rayangler Ah you're very right! That fix was actually introduced in this file in #345. Now that it's merged, I've updated the staging link — you should see the slash now!

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sophstad sophstad merged commit 86a1f8f into master Jan 29, 2021
@sophstad sophstad deleted the improve-canonical branch January 29, 2021 20:32
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants