GODRIVER-2989 A Dockerfile for local development #1381

blink1073 · 2023-09-13T15:45:02Z

GODRIVER-2989

Summary

Adds a Dockerfile and a runner script.

Background & Motivation

Make it easier to test in a reproducible Linux environment.

…-2924

…'t PR author (mongodb#1394)

…b#1392) Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>

matthewdale

Looks good 👍

Dockerfile

etc/docker_entry.sh

docs/CONTRIBUTING.md

Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>

matthewdale

Looks great 👍

Is there any chance we can switch the CI to use this as well, which would force us to keep this up-to-date?

blink1073 · 2023-09-21T02:25:53Z

Well, the tests don't fully pass. For me locally even with bash etc/run_docker.sh test-short I see the following failure:

go test  -tags= -timeout 60s -short ./...
ok  	go.mongodb.org/mongo-driver/benchmark	0.020s [no tests to run]
ok  	go.mongodb.org/mongo-driver/bson	0.212s
--- FAIL: TestTimeCodec (0.00s)
    --- FAIL: TestTimeCodec/UseLocalTimeZone (0.00s)
        --- FAIL: TestTimeCodec/UseLocalTimeZone/true (0.00s)
            time_codec_test.go:44:
                	Error Trace:	/src/bson/bsoncodec/time_codec_test.go:44
                	Error:      	Not equal:
                	            	expected: true
                	            	actual  : false
                	Test:       	TestTimeCodec/UseLocalTimeZone/true
                	Messages:   	Expected UTC: false, got UTC
FAIL
FAIL	go.mongodb.org/mongo-driver/bson/bsoncodec	0.040s

Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>

…ion (mongodb#1404) Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>

…IVER-2924

…nto GODRIVER-2924" This reverts commit 9171dca, reversing changes made to c9a026b.

…-2924

blink1073 · 2023-10-11T13:18:11Z

Okay, this is ready for review again. I added a test, which meant adding a few test skips for docker-specific considerations. I also created a script to install libmongocrypt to avoid repeating code and get us closer to the goal of less code in config.yml. This will also close GODRIVER-2994.

matthewdale

Awesome changes, looks good! 👍

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com> Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> (cherry picked from commit 6d7a981)

GODRIVER-2924 Set up coverage reporting

668d8ae

blink1073 had a problem deploying to api-report September 13, 2023 15:45 — with GitHub Actions Failure

prestonvasquez changed the base branch from master to v1 September 13, 2023 18:06

wip

16ac3d6

blink1073 had a problem deploying to api-report September 13, 2023 22:24 — with GitHub Actions Failure

qingyang-hu and others added 3 commits September 15, 2023 14:19

Quick update for api changes report. (mongodb#1384)

3cc28f4

Make it configurable and add docs

5e3f22e

Merge branch 'v1' of github.com:mongodb/mongo-go-driver into GODRIVER…

83c6c59

…-2924

blink1073 had a problem deploying to api-report September 18, 2023 14:44 — with GitHub Actions Failure

blink1073 changed the title ~~GODRIVER-2924 Set up coverage reporting~~ GODRIVER-2989 A Dockerfile for local development Sep 18, 2023

blink1073 marked this pull request as ready for review September 18, 2023 14:45

blink1073 requested a review from a team as a code owner September 18, 2023 14:45

blink1073 requested review from matthewdale and removed request for a team September 18, 2023 14:45

blink1073 and others added 2 commits September 19, 2023 11:32

GODRIVER-2981 [master] API comment doesn't work when job approver isn…

467dc08

…'t PR author (mongodb#1394)

GODRIVER-2986 [master] Resolve failures in Race Detector Test (mongod…

4b0c121

…b#1392) Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>

matthewdale approved these changes Sep 20, 2023

View reviewed changes

blink1073 and others added 4 commits September 20, 2023 16:21

Update docs/CONTRIBUTING.md

b6a82ec

Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>

Update docs/CONTRIBUTING.md

2a34143

Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>

Update docs/CONTRIBUTING.md

5736345

Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>

address review

53d36e5

blink1073 requested a review from matthewdale September 20, 2023 21:26

blink1073 had a problem deploying to api-report September 20, 2023 21:26 — with GitHub Actions Error

matthewdale previously approved these changes Sep 20, 2023

View reviewed changes

blink1073 added 5 commits September 20, 2023 20:11

add docker test

78937fe

run on ubuntu

0437547

remove interactive flag

3cd44f5

use podman

962ff45

try on ubuntu 20

26928a0

blink1073 added 2 commits September 26, 2023 12:58

try another skip

4c8b29e

fix binary path handling

c9a026b

blink1073 dismissed matthewdale’s stale review via c9a026b September 27, 2023 13:40

blink1073 and others added 12 commits September 27, 2023 16:22

GODRIVER-2982 [master] Add PR build tags. (mongodb#1401)

b02e519

Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>

GODRIVER-2955 [master] Add user-facing network compression documentat…

cd3c699

…ion (mongodb#1404) Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>

Merge branch 'master' of github.com:mongodb/mongo-go-driver into GODR…

9171dca

…IVER-2924

Use source branch

a3d3878

try with alpha version

3dcc04b

try reverting behavior

8c5d62a

whoops

a5e07a9

try with final release

8f0bc14

try this approach

c032558

remove redundant code

d7928f2

Revert "Merge branch 'master' of github.com:mongodb/mongo-go-driver i…

6c73a2b

…nto GODRIVER-2924" This reverts commit 9171dca, reversing changes made to c9a026b.

Merge branch 'v1' of github.com:mongodb/mongo-go-driver into GODRIVER…

ca67293

…-2924

blink1073 marked this pull request as ready for review October 11, 2023 13:16

blink1073 requested a review from matthewdale October 11, 2023 13:18

blink1073 had a problem deploying to api-report October 11, 2023 13:18 — with GitHub Actions Failure

blink1073 added 5 commits October 11, 2023 08:36

remove gnupg

45ffaec

fix path handling

374d492

try direct approach

aa0049b

try again

c87a9f5

cleanup

eb9aed5

matthewdale approved these changes Oct 16, 2023

View reviewed changes

blink1073 merged commit 6d7a981 into mongodb:v1 Oct 16, 2023
35 of 37 checks passed

blink1073 deleted the GODRIVER-2924 branch October 16, 2023 20:38

This was referenced Oct 16, 2023

GODRIVER-2989 [master] A Dockerfile for local development #1428

Merged

GODRIVER-2989 Fix golang installation in Dockerfile #1430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GODRIVER-2989 A Dockerfile for local development #1381

GODRIVER-2989 A Dockerfile for local development #1381

blink1073 commented Sep 13, 2023 •

edited

matthewdale left a comment

matthewdale left a comment

blink1073 commented Sep 21, 2023

blink1073 commented Oct 11, 2023 •

edited

matthewdale left a comment

GODRIVER-2989 A Dockerfile for local development #1381

GODRIVER-2989 A Dockerfile for local development #1381

Conversation

blink1073 commented Sep 13, 2023 • edited

Summary

Background & Motivation

matthewdale left a comment

Choose a reason for hiding this comment

matthewdale left a comment

Choose a reason for hiding this comment

blink1073 commented Sep 21, 2023

blink1073 commented Oct 11, 2023 • edited

matthewdale left a comment

Choose a reason for hiding this comment

blink1073 commented Sep 13, 2023 •

edited

blink1073 commented Oct 11, 2023 •

edited