GODRIVER-2989 [master] A Dockerfile for local development #1428
Conversation
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com> Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> (cherry picked from commit 6d7a981)
blink1073
requested review from
prestonvasquez
and removed request for
a team
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
| @@ -111,6 +114,24 @@ The usage of host.docker.internal comes from the [Docker networking documentatio | |||
|
|
|||
| There is currently no arm64 support for the go1.x runtime, see [here](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html). Known issues running on linux/arm64 include the inability to network with the localhost from the public.ecr.aws/lambda/go Docker image. | |||
|
|
|||
| ### Testing in Docker | |||
|
|
|||
| We support local testing in Docker. Ensure ``docker`` is installed and running, and then run: | |||
There was a problem hiding this comment.
Should we include something about setting the DRIVER_TOOLS environment variable, rather than being informed only via error? E.g.
To test using
docker, you will need to set theDRIVERS_TOOLSenvironment variable to point to a local clone of the drivers-evergreen-tools repository. This is essential for running the testing matrix in a container. You can set theDRIVERS_TOOLSvariable in your shell profile or in your project-specific environment.
There was a problem hiding this comment.
I applied this comment in the follow up PR: #1430
| We support local testing in Docker. Ensure ``docker`` is installed and running, and then run: | ||
|
|
||
| ```bash | ||
| bash etc/run_docker.sh |
There was a problem hiding this comment.
It could be helpful to make this a make target:
.PHONY: build-tests-docker
build-tests-docker:
etc/run_docker.shThere was a problem hiding this comment.
It gets tricky with how to pass args. I thought we eventually want to remove the Makefile altogether?
There was a problem hiding this comment.
Gotcha, that makes sense. Thanks!
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
Cherry-pick of #1381 from v1 to master