Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Specify length of toArray return type #5766

Merged
merged 3 commits into from Oct 29, 2020
Merged

[misc] Specify length of toArray return type #5766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
352dd45
Specify length of toArrary return value
mongoose700 Oct 28, 2020
765638c
Moved the new typing to TypeScript 3.1 + only.
mongoose700 Oct 29, 2020
31bee3f
Add test for toArray's new return type
mongoose700 Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ts3.1-typing-tests/moment-tests.ts
View file
Open in desktop
Expand Up @@ -161,6 +161,8 @@ var getMonth: number = moment().month();
var getQuater: number = moment().quarter();
var getYear: number = moment().year();

var date: [number, number, number, number, number, number, number] = moment().toArray();

moment().hours(0).minutes(0).seconds(0).milliseconds(0);

var a3 = moment([2011, 0, 1, 8]);
Expand Down
2 changes: 1 addition & 1 deletion ts3.1-typings/moment.d.ts
View file
Open in desktop
Expand Up @@ -573,7 +573,7 @@ declare namespace moment {

diff(b: MomentInput, unitOfTime?: unitOfTime.Diff, precise?: boolean): number;

toArray(): number[];
toArray(): [number, number, number, number, number, number, number];
toDate(): Date;
toISOString(keepOffset?: boolean): string;
inspect(): string;
Expand Down