Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Specify length of toArray return type #5766

Merged
merged 3 commits into from Oct 29, 2020
Merged

[misc] Specify length of toArray return type #5766

merged 3 commits into from Oct 29, 2020

Commits on Oct 28, 2020

  1. Specify length of toArrary return value 

    toArray will always return an array with seven numbers. This change is necessary to be able to do `new Date(...m.toArray())`. As just `number[]`, it complains with `Expected 0-7 arguments, but got 0 or more.`.
    @mongoose700
    mongoose700 committed Oct 28, 2020
    Copy the full SHA
    352dd45 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Moved the new typing to TypeScript 3.1 + only.

    @mongoose700
    mongoose700 committed Oct 29, 2020
    Copy the full SHA
    765638c View commit details
    Browse the repository at this point in the history

  2. Add test for toArray's new return type

    @mongoose700
    mongoose700 committed Oct 29, 2020
    1
    Copy the full SHA
    31bee3f View commit details
    Browse the repository at this point in the history