[feature] Implement a clone method for durations, fixes #4078 #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggiepint
requested changes
Jul 25, 2017
src/test/moment/duration.js
Outdated
| var durationB = durationA.clone(); | ||
| durationA.add(5, 'milliseconds'); | ||
| assert.equal(durationB.milliseconds(), 5, 'Calling duration.clone() on a duration will create a clone'); | ||
| assert.equal(durationA.milliseconds(), 10, 'Calling duration.clone() on a duration will create a clone'); |
There was a problem hiding this comment.
It would make more sense to test that durationA.milliseconds() does not equal durationB.milliseconds(). That would test that the object had in fact been cloned more explicitly
There was a problem hiding this comment.
I agree - I've updated code, along with the original unit-tests I copied this logic from.
Closed
ichernev
changed the title
|
Merged in 2847a99 |
ichernev
added a commit
that referenced
this pull request
Aug 7, 2017
[feature] Implement a clone method for durations, fixes #4078
ichernev
added a commit
that referenced
this pull request
Oct 10, 2017
[misc] TS: Add duration.clone(), for #4080
This was referenced Oct 11, 2017
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.