Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Duration.clone() #4078

Closed
ishitatsuyuki opened this issue Jul 21, 2017 · 1 comment · Fixed by LiteHell/js-namumark#3 or willmorgan/heavysignal.co.uk#2
Closed

Add Duration.clone() #4078

ishitatsuyuki opened this issue Jul 21, 2017 · 1 comment · Fixed by LiteHell/js-namumark#3 or willmorgan/heavysignal.co.uk#2

Comments

@ishitatsuyuki
Copy link

Duration lacks the ability to clone (and even no copy constructor), while the arithmetic methods mutates the object. It should have clone().
ashsearle added a commit to ashsearle/moment that referenced this issue Jul 21, 2017
@ashsearle
Fix moment#4078: Implement a clone method for durations
6a87fe9
@maggiepint
Copy link
Member

closed #4080

ichernev pushed a commit that referenced this issue Aug 7, 2017
@ashsearle @ichernev
Fix #4078: Implement a clone method for durations
77b2a3b
ichernev added a commit that referenced this issue Aug 7, 2017
@ichernev
Merge pull request #4080 from ashsearle:fix/4078
2847a99 
[feature] Implement a clone method for durations, fixes #4078
This was referenced Oct 11, 2017
Merged
Closed
fbonzon pushed a commit to fbonzon/moment that referenced this issue Oct 28, 2017
@ashsearle @fbonzon
Fix moment#4078: Implement a clone method for durations
36057ef
This was referenced Mar 12, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maggiepint @ishitatsuyuki