Make Quanta crate optional (but enabled by default) #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Quanta optional and add `quanta` to the default features. - Add `clock_compat` module to provide alternative `Clock` and `Mock` implementations when Quanta is opted out. - Add CI for testing with Quanta opted out. - Reorganize `common::time::*` modules. - Bump Moka version to v0.8.3.
tatsuya6502
added
bug
tatsuya6502
changed the title
Use `atomic_time_compat` module when `quanta` feature is disabled.
Cosmetic changes on source code comments etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for #119, make Quanta crate optional and add
quantato the default features.clock_compatmodule to provide alternativeClockandMockimplementations when Quanta is opted out.common::time::*modules.