Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Rollup, use moduleSideEffects flag #1983

Merged
merged 2 commits into from Jun 19, 2022
Merged

Conversation

web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Jun 5, 2022

What I did

  1. Updated rollup dependency range to ^2.67.0 to get latest version 2.75.5 installed
  2. Added the new moduleSideEffects flag in addition to the the deprecated hasModuleSideEffects
  3. Added the null check to fix Property 'code' does not exist on type 'void | SourceDescription'.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2022

🦋 Changeset detected

Latest commit: d948704

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@web/dev-server-rollup Patch
@web/dev-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LarsDenBakker LarsDenBakker merged commit 78d610d into master Jun 19, 2022
@LarsDenBakker LarsDenBakker deleted the fix/rollup-flag branch June 19, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants