chore: fix compilation errors

modernweb-dev · Jun 19, 2022 · 78d610d · 78d610d
1 parent fee4572
commit 78d610d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/chatty-ghosts-argue.md b/.changeset/chatty-ghosts-argue.md
@@ -0,0 +1,6 @@
+---
+'@web/dev-server-rollup': patch
+'@web/dev-server': patch
+---
+
+Update Rollup, use moduleSideEffects flag
diff --git a/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts b/packages/dev-server-rollup/src/createRollupPluginContextAdapter.ts
@@ -38,6 +38,7 @@ export function createRollupPluginContextAdapter<
         isEntry: false,
         isExternal: false,
         isIncluded: false,
+        hasModuleSideEffects: false,
         moduleSideEffects: false,
         syntheticNamedExports: false,
         meta: pluginMetaPerModule.get(id) ?? {},

diff --git a/packages/dev-server-rollup/src/rollupAdapter.ts b/packages/dev-server-rollup/src/rollupAdapter.ts
@@ -295,7 +295,7 @@ export function rollupAdapter(
         if (typeof result === 'string') {
           return { body: result, type: 'js' };
         }
-        if (typeof result?.code === 'string') {
+        if (result != null && typeof result?.code === 'string') {
           savePluginMeta(filePath, result);
           return { body: result.code, type: 'js' };
         }