feat: update puppeteer and puppeteer-core to 8.0.0 #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b23b0a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for this! Puppeteer v7 ships it's own types now, so if we update we will need to remove the types package as well. |
|
@LarsDenBakker rebased and removed |
web-padawan
commented
Feb 18, 2021
web-padawan
commented
Feb 23, 2021
Comment on lines
2
to
3
| import * as puppeteerCore from 'puppeteer-core'; | ||
| import { Browser, Page } from 'puppeteer-core'; |
There was a problem hiding this comment.
These imports are added as a workaround for puppeteer/puppeteer#6904, let's wait for it to be fixed.
web-padawan
changed the title
|
Thanks for this, sorry it took so long to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
puppeteer-coreandpuppeteerversions to 8.0.0Closes #1254
Closes #1255
Closes #1260
Closes #1261
Closes #1322
Closes #1323