puppeteer-core types differ from puppeteer

[Niek]

I'm maintaining the puppeteer add-on ghost-cursor and while upgrading the dependency to puppeteer@7 I noticed some strange differences between puppeteer and puppeteer-core types. For example the Page class is not interchangeable:

 error TS2345: Argument of type 'import("node_modules/puppeteer/lib/types").Page' is not assignable to parameter of type 'import("node_modules/puppeteer-core/lib/types").Page'.
  Types have separate declarations of a private property '_closed'.

Strange enough I can't find the differences in the generated types.d.ts files:

$ diff node_modules/puppeteer/lib/types.d.ts  node_modules/puppeteer-core/lib/types.d.ts | wc -l
       0

Any idea how this can be fixed? I would prefer to keep using puppeteer-core in the library while users most of the time use the regular puppeteer library.

[web-padawan]

I noticed this too, while trying to upgrade puppeteer version for @web/test-runner-puppeteer package.

See modernweb-dev/web#1295 (review) for one example where it caused TS compilation errors.

[web-padawan]

@jackfranklin as you mentioned that you are going through the types #6979 (comment), could you please check this one too?

[JakeTompkins]

Is there any progress on this? I'd like to use chrome-aws-lambda which uses puppeteer-core with a custom fork of html-pdf-node-ts which uses puppeteer, but I can't reconcile the types of Browser between the two

[stale]

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

[kldzj]

This is still an issue.

[luna-fire-dev]

This is because import('puppeteer').Page and import('puppeteer-core').Page are two different classes defined in two different js files from two different modules (so are the two types in two d.ts files). I am wondering why puppeteer doesn't import puppeteer-core as a dependency and re-use the classes from puppeteer-core.

[OrKoN]

@luna-fire-dev that'd be our plan but it's not how it was originally set up (when it was JS with no typescript in sight) so it will take some time to untangle it.

[rpodwika]

any updates on that?

[OrKoN]

That should work in the latest versions as puppeteer-core is a dependency for puppeteer now.