New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes mockito#2311 #2320
Merged
Merged
Fixes mockito#2311 #2320
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,4 +48,28 @@ private static boolean safelyMatches(ArgumentMatcher m, Object arg) { | |
private static boolean toStringEquals(ArgumentMatcher m, Object arg) { | ||
return m.toString().equals(String.valueOf(arg)); | ||
} | ||
|
||
/** | ||
* Suspiciously not matching arguments are those that don't match, and the classes have same simple name. | ||
*/ | ||
public static Integer[] getNotMatchingArgsWithSameNameIndexes( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather than returning Integers, can we instead return all names that have duplicates? Then we can do the lookup on the name. E.g. return a |
||
List<ArgumentMatcher> matchers, Object[] arguments) { | ||
if (matchers.size() != arguments.length) { | ||
return new Integer[0]; | ||
} | ||
|
||
List<Integer> suspicious = new LinkedList<>(); | ||
int i = 0; | ||
for (ArgumentMatcher m : matchers) { | ||
if (m instanceof ContainsExtraTypeInfo | ||
&& !safelyMatches(m, arguments[i]) | ||
&& !((ContainsExtraTypeInfo) m).typeMatches(arguments[i]) | ||
&& ((ContainsExtraTypeInfo) m).sameName(arguments[i])) { | ||
suspicious.add(i); | ||
} | ||
i++; | ||
} | ||
return suspicious.toArray(new Integer[0]); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not the biggest fan of adding another method here. Especially as it is very similar to the
toStringWithType()
, but the only difference is the name retrieval.What if instead we get the wanted object and perform the computation in the
MatchersPrinter
? E.g. avoid introductions of new methods and pass in the desired name intotoStringWithType(String className)