Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mockito#2311 #2320

Merged
merged 4 commits into from Jun 26, 2021
Merged

Fixes mockito#2311 #2320

merged 4 commits into from Jun 26, 2021

Commits on Jun 9, 2021

  1. Fixes mockito#2311

    Prints fully qualified class name when the simple names of arguments match.
    thisisdexter committed Jun 9, 2021
    Copy the full SHA
    d544cfc View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Fixes mockito#2311

    Made changes to Equals.toStringWithType by reusing same method to achieve both cases by sending a boolean as an input, based on which either simple name or fully qualified name will be used for describing the type.
    
    Also in the method ArgumentMatchingTool.getNotMatchingArgsWithSameName return Set<String> which return the simple names of classes having more than one classes with different FQCN.
    thisisdexter committed Jun 13, 2021
    Copy the full SHA
    446c5fe View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Have refactored the changes in MatchersPrinter.

    In Equals have passed qualified class name instead of the boolean.
    Also removed getWantedClass and instead made getWanted public and used it.
    Have also added 3 test cases for cases where some arguments have same simple class name.
    thisisdexter committed Jun 26, 2021
    Copy the full SHA
    265e995 View commit details
    Browse the repository at this point in the history
  2. Fixes mockito#2311

    Fixed the style issues, by running gradlew :spotlessApply
    
    Also needed to handle the case where argument is null, which gave null pointer while getting class name from the object.
    thisisdexter committed Jun 26, 2021
    Copy the full SHA
    a84e177 View commit details
    Browse the repository at this point in the history