Updated version of glob package to latest version
#2123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies are deprecated.
|
Can someone kindly merge this PR please. |
|
Actually can you bump that 3 patch versions? - https://github.com/isaacs/node-glob/blob/2fc2278ab857c7df117213a2fb431de090be6353/package.json 7.0.3 is out |
|
+1 This outdated dep also causes issues with the upcoming new release of Meteor, requiring a bunch of workarounds to test Meteor apps. (ref meteor/meteor#6430 (comment)) |
|
@SamuelMarks I updated |
|
There was a duplicate (#2144) that was merged |
|
@dmsakamoto #2144 was not merged. It was closed as dup of this issue. |
|
|
|
Hey all, can we move the discussion to #2121 ? :) |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM says
globdependencygraceful-fs@2.0.3is deprecated and will cause newer versions of Node to crash.So I upgraded
globfrom version@3.2.3to@7.0.0, which is the latest version. This version ofglobalso no longer usesgraceful-fsas a dependency.Finally, this update passed all of the tests.
mochaTestOutput.txt