Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Update dependencies that use a deprecated version of graceful-fs #75

Closed
1 of 2 tasks
zeke opened this issue Mar 17, 2016 · 6 comments
Closed
1 of 2 tasks

Update dependencies that use a deprecated version of graceful-fs #75

zeke opened this issue Mar 17, 2016 · 6 comments

Comments

@zeke
Copy link
Contributor

zeke commented Mar 17, 2016

❯ npm i              
npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
npm WARN deprecated graceful-fs@2.0.3: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

The Offenders

This is kind of a wild goose chase, as the dependency is pretty deep in the tree in some spots. The two top-level offenders are mocha and eletron-packager.

❯ npm ls graceful-fs@'<4'
electron-api-demos@1.0.0 /Users/zeke/atom/electron-api-demos
├─┬ electron-packager@5.2.1
│ └─┬ asar@0.8.3
│   └─┬ mksnapshot@0.1.0
│     └─┬ decompress-zip@0.1.0
│       └── graceful-fs@3.0.8 
└─┬ mocha@2.4.5
  └─┬ glob@3.2.3
    └── graceful-fs@2.0.3 

Outstanding PRs

@jlord
Copy link
Contributor

jlord commented Mar 18, 2016

Yeah this would be nice to clean up 👍 Worth noting since the majority of end users will be downloading an executable they won't see this. But it will be open source and people building locally, including us, will 😓

@jlord
Copy link
Contributor

jlord commented Apr 13, 2016

@zeke per ☝️ on decompress-zip are we one closer to resolving this issue?

Note, I'm going to add checkboxes to the original post and update the mocha ref which has changed

@zeke
Copy link
Contributor Author

zeke commented Apr 14, 2016

├─┬ electron-packager@5.2.1
│ └─┬ asar@0.8.3
│   └─┬ mksnapshot@0.1.0
│     └─┬ decompress-zip@0.1.0
│       └── graceful-fs@3.0.8 

We've upstreamed as far as mksnapshot. @kevinsawicki said he would pick up the slack to publish a new asar, and finally electron-packager.

@kevinsawicki
Copy link
Contributor

said he would pick up the slack to publish a new asar

asar@0.11 was published with the fix 🚢

@kevinsawicki
Copy link
Contributor

Looks like electron-packager picked it up in 6.0.1

electron/packager@be6eb2d

@jlord
Copy link
Contributor

jlord commented Apr 28, 2016

I think we've done what we could do here for now 👍

@jlord jlord closed this as completed Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants