split exported functions from implementation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
split_implementations
branch
2 times, most recently
from
fcf5dfd
to
c4f1041
Compare
|
This one's best reviewed commit-by-commit (as some files are renamed / moved) |
thaJeztah
force-pushed
the
split_implementations
branch
from
c4f1041
to
37959b0
Compare
thaJeztah
force-pushed
the
split_implementations
branch
3 times, most recently
from
0d8209e
to
0591815
Compare
Aligning functions to be in the same files for each platform. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
split_implementations
branch
from
0591815
to
a97a578
Compare
rumpl
approved these changes
May 2, 2023
Put the exported functions in a non-platform-specific file, and un-export the implementations. This allows us to maintain the GoDoc for exported functions in a single place (not having to repeat those), and make sure that the signatures between platforms are identical (unless not possible). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
split_implementations
branch
from
a97a578
to
bb04910
Compare
|
@rumpl doh! had one minor change stashed, and forgot to push 🙈 just did; PTAL; https://github.com/moby/term/compare/a97a5788274f401b12126432d8c4c4ee3b677a0c..bb04910d7c2ef73ab41c05aa452f86b6ac1ae7b4 |
|
CI is still happy; bringing this one in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the exported functions in a non-platform-specific file, and
un-export the implementations. This allows us to maintain the
GoDoc for exported functions in a single place (not having to
repeat those), and make sure that the signatures between platforms
are identical (unless not possible).