Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate Termios in favor of unix.Termios #37

Merged
merged 1 commit into from
Apr 30, 2023
Merged

deprecate Termios in favor of unix.Termios #37

merged 1 commit into from
Apr 30, 2023

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah thaJeztah mentioned this pull request Apr 30, 2023
Merged
2 tasks
@thaJeztah
Copy link
Member Author

@AkihiroSuda @dims @cpuguy83 ptal

@thaJeztah
deprecate Termios in favor of unix.Termios
80ddd80 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dims
dims approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx! I'll bring this one in, and rebase #41 (and move it out of draft)

@thaJeztah thaJeztah merged commit 0564e01 into moby:master Apr 30, 2023
11 checks passed
@thaJeztah thaJeztah deleted the deprecate_termios branch April 30, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaJeztah @dims