New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore active mount counts on live-restore #45754
Restore active mount counts on live-restore #45754
Conversation
e0e26f7
to
6781308
Compare
3c57ca9
to
19d651c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docker-py failure can be ignored and is unrelated (fixed on master) |
@corhere @neersighted @vvoland PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, the logs need to be adjusted now though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One logging nit, otherwise LGTM.
19d651c
to
f1b6b87
Compare
When live-restoring a container the volume driver needs be notified that there is an active mount for the volume. Before this change the count is zero until the container stops and the uint64 overflows pretty much making it so the volume can never be removed until another daemon restart. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
f1b6b87
to
647c2a6
Compare
Looks like we should add a -f in the github actions as well;
|
Thanks for all of your work on this issue + fix @cpuguy83. |
Sorry it took so long to recognize where the issue was! |
When live-restoring a container the volume driver needs be notified that there is an active mount for the volume.
Before this change the count is zero until the container stops and the uint64 overflows pretty much making it so the volume can never be removed until another daemon restart.
Fixes #44422