[20.10] Backport Restore active mount counts on live-restore #45840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/volumes
area/daemon
kind/bugfix
corhere
reviewed
Jun 28, 2023
volume/mounts/mounts.go
Outdated
| @@ -10,8 +11,10 @@ import ( | |||
| "github.com/docker/docker/pkg/idtools" | |||
| "github.com/docker/docker/pkg/stringid" | |||
| "github.com/docker/docker/volume" | |||
| "github.com/docker/swarmkit/log" | |||
There was a problem hiding this comment.
swarmkit/log? Was that intended?
Backporting commit 647c2a6 for 20.10 When live-restoring a container the volume driver needs be notified that there is an active mount for the volume. Before this change the count is zero until the container stops and the uint64 overflows pretty much making it so the volume can never be removed until another daemon restart. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
20.10_fix_live_restore_local_vol_mounts
branch
from
a356a4e
to
b5fe60d
Compare
corhere
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting commit 647c2a6 for 20.10
When live-restoring a container the volume driver needs be notified that there is an active mount for the volume.
Before this change the count is zero until the container stops and the uint64 overflows pretty much making it so the volume can never be removed until another daemon restart.