New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon/graphdriver/windows: various cleanups and fixes #44282
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
605e8f5
daemon/graphdriver/windows: InitFilter() don't use idtools.MkdirAllAn…
thaJeztah 3a8c97b
daemon/graphdriver/windows: rename vars that collided with imports
thaJeztah d742188
daemon/graphdriver/windows: remove fileFlagSequentialScan const
thaJeztah 9db5dc9
daemon/graphdriver/windows: use strings.EqualFold()
thaJeztah bbeaeee
daemon/graphdriver/windows: remove some intermediate variables
thaJeztah 3b569cc
daemon/graphdriver/windows: cleanup errors
thaJeztah File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New options should be case-sensitive, but I think we're stuck with case-folding for
size
for back-compat reasons unless we have a flag day.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need to look how we can get out of this situation. Some of these came from situations where "Windows filesystem is case-insensitive, so options should be case-insensitive as well", or just "make it easier to use"). Reality is that in many cases this logic is "distributed", and in some cases may have some potential bugs lurking around. For example, in the overlay2 driver; parsing storage options is case-insensitive;
moby/daemon/graphdriver/overlay2/overlay.go
Lines 426 to 428 in b3428bc
But other parts in the same file doesn't take case-insensitivity into account;
moby/daemon/graphdriver/overlay2/overlay.go
Lines 322 to 340 in b3428bc