Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon/graphdriver/windows: various cleanups and fixes #44282

Merged
merged 6 commits into from Mar 14, 2023
Merged

daemon/graphdriver/windows: various cleanups and fixes #44282

merged 6 commits into from Mar 14, 2023

Commits on Mar 14, 2023

  1. daemon/graphdriver/windows: InitFilter() don't use idtools.MkdirAllAn… 

    …dChown()

idtools.MkdirAllAndChown on Windows does not chown directories, which makes
idtools.MkdirAllAndChown() just an alias for system.MkDirAll().

Also setting the filemode to `0`, as changing filemode is a no-op on Windows as
well; both of these changes should make it more transparent that no chown'ing,
nor changing filemode takes place.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    605e8f5 View commit details
    Browse the repository at this point in the history

  2. daemon/graphdriver/windows: rename vars that collided with imports 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3a8c97b View commit details
    Browse the repository at this point in the history

  3. daemon/graphdriver/windows: remove fileFlagSequentialScan const 

    Replace it with the const that's now defined in golang.org/x/sys/windows

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d742188 View commit details
    Browse the repository at this point in the history

  4. daemon/graphdriver/windows: use strings.EqualFold() 

    Saves some allocations

    BenchmarkTolower
    BenchmarkTolower-5     7917788       150.4 ns/op      16 B/op       3 allocs/op
    BenchmarkEqualFold
    BenchmarkEqualFold-5   8248605       143.5 ns/op       8 B/op       1 allocs/op

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9db5dc9 View commit details
    Browse the repository at this point in the history

  5. daemon/graphdriver/windows: remove some intermediate variables 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bbeaeee View commit details
    Browse the repository at this point in the history

  6. daemon/graphdriver/windows: cleanup errors 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3b569cc View commit details
    Browse the repository at this point in the history