Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Flaky tests on powerpc and z #38423

Merged

Conversation

olljanat
Copy link
Contributor

@olljanat olljanat commented Dec 23, 2018

Disabled these tests on s390x and ppc64le:

because they are known to be flaky.

@derek derek bot added the area/testing label Dec 23, 2018
@olljanat olljanat force-pushed the disable-integration-tests-on-z-and-powerpc branch from 99299e4 to adae6ba Compare December 23, 2018 12:01
@derek derek bot added the rebuild/z label Dec 23, 2018
@olljanat olljanat force-pushed the disable-integration-tests-on-z-and-powerpc branch from adae6ba to 9678faf Compare December 23, 2018 17:03
@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #38423 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38423      +/-   ##
==========================================
- Coverage   36.55%   36.54%   -0.02%     
==========================================
  Files         608      608              
  Lines       45036    45036              
==========================================
- Hits        16465    16458       -7     
- Misses      26293    26299       +6     
- Partials     2278     2279       +1

@olljanat olljanat force-pushed the disable-integration-tests-on-z-and-powerpc branch 6 times, most recently from 49ef268 to 25c150c Compare December 24, 2018 11:48
- TestAPISwarmLeaderElection
- TestAPISwarmRaftQuorum
- TestSwarmClusterRotateUnlockKey

because they are known to be flaky.

Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
@olljanat olljanat force-pushed the disable-integration-tests-on-z-and-powerpc branch from 25c150c to 02157c6 Compare December 24, 2018 11:51
@olljanat olljanat changed the title WIP: Disabled Flaky tests on powerpc and z Disabled Flaky tests on powerpc and z Dec 24, 2018
@olljanat
Copy link
Contributor Author

@vdemeester @thaJeztah after couple of tests runs looks that this change would make CI more stable so question is that can we do it or is it necessary run these tests on powerpc and z (other build servers are still running them)?

@kolyshkin
Copy link
Contributor

👍 yes please

LGTM

@olljanat
Copy link
Contributor Author

olljanat commented Jan 3, 2019

@thaJeztah PTAL

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants