Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated grpc.ErrorDesc() and grpc.Code() calls #38450

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Replace deprecated grpc.ErrorDesc() and grpc.Code() calls #38450

merged 1 commit into from
Jan 5, 2019

Conversation

thaJeztah
Copy link
Member

@thaJeztah
Replace deprecated grpc.ErrorDesc() and grpc.Code() calls
72b0b03 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the remove_deprecated_grpc_functions branch from 60802db to 72b0b03 Compare December 30, 2018 11:34
@codecov
Copy link

codecov bot commented Dec 30, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@f76d6a0). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38450   +/-   ##
=========================================
  Coverage          ?   36.55%           
=========================================
  Files             ?      608           
  Lines             ?    45040           
  Branches          ?        0           
=========================================
  Hits              ?    16464           
  Misses            ?    26293           
  Partials          ?     2283

@thaJeztah thaJeztah changed the title Replace deprecated grpc.ErrorDesc() calls Replace deprecated grpc.ErrorDesc() and grpc.Code() calls Dec 30, 2018
@derek derek bot added the rebuild/* label Dec 31, 2018
@olljanat
Copy link
Contributor

olljanat commented Dec 31, 2018 •
edited

PowerPC and Z failed to #38460

and then PowerPC failed twice to those errors which are disabled on #38423

@derek derek bot added the rebuild/z label Dec 31, 2018
@derek derek bot added the rebuild/powerpc label Jan 1, 2019
@derek derek bot added the rebuild/powerpc label Jan 1, 2019
vdemeester
vdemeester approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

cpuguy83
cpuguy83 approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 6825db8 into moby:master Jan 5, 2019
@thaJeztah thaJeztah deleted the remove_deprecated_grpc_functions branch January 5, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thaJeztah @olljanat @vdemeester @cpuguy83 @GordonTheTurtle