Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Feat(root): Apply code format on commit #117

Closed
wants to merge 2 commits into from
Closed

Feat(root): Apply code format on commit #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37a0aee
#115: setup code format on pre-commmit hook with husky and lint-staged
lqt93 Mar 31, 2021
b4e45d5
#115: create husky config
lqt93 Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
node_modules
dist
.DS_Store
.idea
.idea
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a big deal but usually I'd prefer new line at end file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, please help me to add a new line at end file @lqt93

1 change: 1 addition & 0 deletions .husky/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuhuynh27 @lqt93 sorry, just a small question, what does this mean?

4 changes: 4 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged
11 changes: 11 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "@moai/root",
"lint-staged": {
"*.{ts,tsx,js,css,json}": "prettier --write"
},
"devDependencies": {
"husky": "^6.0.0",
"lint-staged": "^10.5.4",
"prettier": "^2.2.1"
}
Comment on lines +6 to +10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqt93 I'm sorry but can you use exact version? It's just I want to manually control the dependencies upgrading

}