Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Feat(root): Apply code format on commit #117

Closed
wants to merge 2 commits into from
Closed

Feat(root): Apply code format on commit #117

wants to merge 2 commits into from

Conversation

lqt93
Copy link
Contributor

@lqt93 lqt93 commented Apr 1, 2021 •
edited

@vercel
Copy link

vercel bot commented Apr 1, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

moai-core – ./core

🔍 Inspect: https://vercel.com/makeinvietnam/moai-core/GWiRTvv1AKbAE59AE8cudMiVrn1d
✅ Preview: https://moai-core-git-fork-lqt93-prettier-on-commit-makeinvietnam.vercel.app

moai-site – ./site

🔍 Inspect: https://vercel.com/makeinvietnam/moai-site/EUHJDjTPN8whAPrmh2FkRdRZwEVY
✅ Preview: https://moai-site-git-fork-lqt93-prettier-on-commit-makeinvietnam.vercel.app

tuhuynh27
tuhuynh27 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@tuhuynh27 tuhuynh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thien-do
thien-do suggested changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@thien-do thien-do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR @lqt93 ! Just some small questions

.husky/.gitignore
@@ -0,0 +1 @@
_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuhuynh27 @lqt93 sorry, just a small question, what does this mean?

.gitignore
@@ -1,4 +1,4 @@
node_modules
dist
.DS_Store
.idea
.idea
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a big deal but usually I'd prefer new line at end file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, please help me to add a new line at end file @lqt93

package.json
Comment on lines +6 to +10
"devDependencies": {
"husky": "^6.0.0",
"lint-staged": "^10.5.4",
"prettier": "^2.2.1"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqt93 I'm sorry but can you use exact version? It's just I want to manually control the dependencies upgrading

@thien-do
Copy link
Collaborator

thien-do commented Apr 9, 2021

Oh looks like we can merge https://github.com/moaijs/moai/pull/135/files which includes this! Great work @lqt93 !

@thien-do thien-do closed this Apr 9, 2021
@lqt93 lqt93 deleted the prettier-on-commit branch April 10, 2021 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tuhuynh27 tuhuynh27 tuhuynh27 approved these changes

@thien-do thien-do thien-do requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lqt93 @thien-do @tuhuynh27