Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused xml2 in R #5219

Merged
merged 3 commits into from Jan 6, 2022
Merged

Remove unused xml2 in R #5219

merged 3 commits into from Jan 6, 2022

Conversation

harupy
Copy link
Member

@harupy harupy commented Jan 5, 2022

What changes are proposed in this pull request?

Today I found the latest check for mlflow on CRAN says:

Version: 1.22.0
Check: dependencies in R code
Result: NOTE
    Namespace in Imports field not imported from: ‘xml2’
     All declared Imports should be used.

This PR fixes this issue.

How is this patch tested?

Added a check to detect unused imports and confirmed it passed.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Jan 5, 2022
Signed-off-by: harupy <hkawamura0130@gmail.com>
Comment on lines +16 to +22
# This runs checks that are disabled when `cran` is TRUE (e.g. unused import check).
devtools::check_built(
path = package,
cran = FALSE,
error_on = "note",
args = "--no-tests"
)
Copy link
Member Author

@harupy harupy Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took 35.3s: https://github.com/mlflow/mlflow/runs/4716826204?check_suite_focus=true#step:13:197 which actually isn't short but acceptable.

Signed-off-by: harupy <hkawamura0130@gmail.com>
@@ -105,7 +105,7 @@ jobs:
cd mlflow/R/mlflow
R CMD build .
cd tests
Rscript ../.create-test-env.R
Rscript 'source("../.create-test-env.R", echo=TRUE)'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equivalent to set -x for bash.

Signed-off-by: harupy <hkawamura0130@gmail.com>
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harupy harupy merged commit 080c058 into mlflow:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants