Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused xml2 in R #5219

Merged
merged 3 commits into from Jan 6, 2022
Merged

Remove unused xml2 in R #5219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ba0ec1
remove xml2
harupy Jan 5, 2022
a6dbefd
use source with echo=TRUE
harupy Jan 6, 2022
5b52775
add -e
harupy Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ jobs:
cd mlflow/R/mlflow
R CMD build .
cd tests
Rscript ../.create-test-env.R
Rscript -e 'source("../.create-test-env.R", echo=TRUE)'
- name: Run tests
env:
# Hack to get around this issue:
Expand All @@ -120,7 +120,7 @@ jobs:
cd mlflow/R/mlflow/tests
# `devtools::check_built` requires `pandoc` to analyze README.md
sudo apt-get install pandoc -y
Rscript ../.run-tests.R
Rscript -e 'source("../.run-tests.R", echo=TRUE)'
- name: Calculate code coverage
if: ${{ success() }}
run: |
Expand Down
8 changes: 8 additions & 0 deletions mlflow/R/mlflow/.run-tests.R
View file
Open in desktop
Expand Up @@ -8,8 +8,16 @@ use_condaenv(mlflow:::mlflow_conda_env_name())

devtools::check_built(
path = package,
cran = TRUE,
remote = should_enable_cran_incoming_checks(),
error_on = "note",
args = "--no-tests"
)
# This runs checks that are disabled when `cran` is TRUE (e.g. unused import check).
devtools::check_built(
path = package,
cran = FALSE,
error_on = "note",
args = "--no-tests"
)
Comment on lines +16 to +22
Copy link
Member Author

@harupy harupy Jan 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took 35.3s: https://github.com/mlflow/mlflow/runs/4716826204?check_suite_focus=true#step:13:197 which actually isn't short but acceptable.

source("testthat.R")
1 change: 0 additions & 1 deletion mlflow/R/mlflow/DESCRIPTION
View file
Open in desktop
Expand Up @@ -46,7 +46,6 @@ Imports:
swagger,
tibble (>= 2.0.0),
withr,
xml2,
yaml,
zeallot
Suggests:
Expand Down