Remove unused xml2 in R (#5219)

* remove xml2 Signed-off-by: harupy <hkawamura0130@gmail.com> * use source with echo=TRUE Signed-off-by: harupy <hkawamura0130@gmail.com> * add -e Signed-off-by: harupy <hkawamura0130@gmail.com>
mlflow · Jan 6, 2022 · 080c058 · 080c058
1 parent 8f675ca
commit 080c058
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -105,7 +105,7 @@ jobs:
         cd mlflow/R/mlflow
         R CMD build .
         cd tests
-        Rscript ../.create-test-env.R
+        Rscript -e 'source("../.create-test-env.R", echo=TRUE)'
     - name: Run tests
       env:
         # Hack to get around this issue:
@@ -120,7 +120,7 @@ jobs:
         cd mlflow/R/mlflow/tests
         # `devtools::check_built` requires `pandoc` to analyze README.md
         sudo apt-get install pandoc -y
-        Rscript ../.run-tests.R
+        Rscript -e 'source("../.run-tests.R", echo=TRUE)'
     - name: Calculate code coverage
       if: ${{ success() }}
       run: |

diff --git a/mlflow/R/mlflow/.run-tests.R b/mlflow/R/mlflow/.run-tests.R
@@ -8,8 +8,16 @@ use_condaenv(mlflow:::mlflow_conda_env_name())
 
 devtools::check_built(
     path = package,
+    cran = TRUE,
     remote = should_enable_cran_incoming_checks(),
     error_on = "note",
     args = "--no-tests"
 )
+# This runs checks that are disabled when `cran` is TRUE (e.g. unused import check).
+devtools::check_built(
+    path = package,
+    cran = FALSE,
+    error_on = "note",
+    args = "--no-tests"
+)
 source("testthat.R")
diff --git a/mlflow/R/mlflow/DESCRIPTION b/mlflow/R/mlflow/DESCRIPTION
@@ -46,7 +46,6 @@ Imports:
     swagger,
     tibble (>= 2.0.0),
     withr,
-    xml2,
     yaml,
     zeallot
 Suggests: