Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Truncated values in sortBy column #5018

Merged
merged 3 commits into from Nov 8, 2021
Merged

Conversation

NieuweNils
Copy link
Contributor

@NieuweNils NieuweNils commented Nov 7, 2021

What changes are proposed in this pull request?

Increase the width of the dropdown so that sort by options do not get truncated in case of long names. (see issue #4822)

How is this patch tested?

Ran the unit tests using pytest

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.

  • Yes. Give a description of this change to be included in the release notes for MLflow users.

-->Increase width of "sort by" column such that bigger parameter keys are not truncated. (Also include @coder-freestyle in the release note)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging

  • area/build: Build and test infrastructure for MLflow

  • area/docs: MLflow documentation pages

  • area/examples: Example code

  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry

  • area/models: MLmodel format, model serialization/deserialization, flavors

  • area/projects: MLproject format, project running backends

  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs

  • area/server-infra: MLflow Tracking server backend

  • area/tracking: Tracking Service, tracking client APIs, autologging

    Interface

    • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models

  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry

  • area/windows: Windows support

Language

  • language/r: R APIs and clients

  • language/java: Java APIs and clients

  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations

  • integrations/sagemaker: SageMaker integrations

  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section

  • rn/feature - A new user-facing feature worth mentioning in the release notes

    • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

@NieuweNils Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/4133046855. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.

NieuweNils added 2 commits November 7, 2021 23:54
…een width

Signed-off-by: NieuweNils <NieuweNils.OSS@protonmail.com>
Signed-off-by: NieuweNils <NieuweNils.OSS@protonmail.com>
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a significant improvement! Thanks @NieuweNils @coder-freestyle!

Signed-off-by: dbczumar <corey.zumar@databricks.com>
@dbczumar
Copy link
Collaborator

dbczumar commented Nov 8, 2021

@NieuweNils I fixed a small lint issue and bumped the min width to 30%

@NieuweNils
Copy link
Contributor Author

Will keep the linter in mind for future contributions!

@dbczumar
Copy link
Collaborator

dbczumar commented Nov 8, 2021

Will keep the linter in mind for future contributions!

No worries!

@dbczumar dbczumar added rn/bug-fix Mention under Bug Fixes in Changelogs. area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server labels Nov 8, 2021
@dbczumar dbczumar merged commit d754523 into mlflow:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants